This meme was brought to you by the PyPI Director of Infrastructure who accidentally hardcoded credentials - which could have resulted in compromissing the entire core Python ecosystem.

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 4 points 1 month ago (9 children)

@carrylex git should be password manager aware and refuse to commit if changes include a password

[–] [email protected] 9 points 1 month ago* (last edited 1 month ago) (2 children)

Well from my personal PoV there are a few problems with that

You can't detect all credentials reliably, they could be encoded in base64 for example
I think it's kind of okay to commit credentials and configuration used for the local dev environment (and ONLY the local one). E.g. when you require some infrastructure like a database inside a container for your app. Not every dev wants to manually set a few dozen configuration entries when they quickly want to checkout and run the app

[–] [email protected] 15 points 1 month ago (1 children)

You can’t detect all credentials reliably,

Easy. You check in the password file first. Then you can check if the codebase contains any entry on the blacklist.

Wait…

[–] [email protected] 13 points 1 month ago (2 children)

You were so close! The right solution is of course training an AI model that detects credentials and rejects commits that contain them!

[–] tyler 7 points 1 month ago

You joke, but GitHub advanced security does this and more. On top of the AI component, they check the hash of all things that look like an api key and then also check them against their integrated vendors to see if they’re non-expired. I don’t know how well it works, but they claim like a .1% false positive rate or something like that.

[–] MajorHavoc 6 points 1 month ago

I need one of those reminder bots, so I can share a link to an inevitable startup, six months from now, based on your humorous comment.

[–] [email protected] 10 points 1 month ago

I think it's kind of okay to commit credentials and configuration used for the local dev environment (and ONLY the local one).

No. Never.

E.g. when you require some infrastructure like a database inside a container for your app. Not every dev wants to manually set a few dozen configuration entries when they quickly want to checkout and run the app

In this situation, it would be better to write a simple script that can generate fresh and unique values for the dev.

Laziness is not an excuse.

load more comments (6 replies)