this post was submitted on 23 Mar 2025
52 points (96.4% liked)

Programming

19255 readers
87 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]



founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[โ€“] lysdexic 16 points 1 week ago (1 children)

Consistency is NOT the most important thing. Correctness is.

What point do you think you're making? I mean, do you think anyone looks at a PR and says "this PR is clearly wrong, but it's so consistent that I must approve it." That's obviously not the point, is it?

[โ€“] FizzyOrange 1 points 1 week ago

I've definitely seen "this is more correct, but all the other code does it like this so can you change it?"

I can't say I entirely disagree with it either - usually the "more correct" is not "the existing code doesn't work at all", and keeping it consistent makes it easier to fix all of the code later, because you're only fixing one style instead of two (or more).