Yeah I mean obviously the technical points here are correct (and I wish my colleagues would write more robust code with less Bash and regex all over the place), but I don't know why he thinks you need an asshole manager to deliver that message.
Over-engineered. Too many moving parts. Refactor.”
That was it. No “nice work.” No “good attempt”. Just a hard stop.
Uhm yeah, would writing "good attempt" have hurt? Obviously not. He could easily have been nice and still deliver the technical information.
Good attempt, but I think this is too over-engineered with too many moving parts. For instance x y z would be simpler to maintain, and a b c isn't robust to 1 2 3 for example.
It doesn't take much. Don't be a dick.