this post was submitted on 14 May 2024
20 points (100.0% liked)

C Sharp

1532 readers
2 users here now

A community about the C# programming language

Getting started

Useful resources

IDEs and code editors

Tools

Rules

Related communities

founded 1 year ago
MODERATORS
Ategon
nibblebit
Spyros
20
Writing “string.IsNullOrEmpty” using pattern matching and comparing the resulting code (www.tabsoverspaces.com)
submitted 6 months ago by SmartmanApps to c/csharp
4 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 4 points 6 months ago (2 children)

string.IsNullOrEmpty(myStr) has always annoyed me, why isn't it an extension method or a non-static method?

myStr.IsNullOrEmpty() just feels cleaner and more intuitive to me.

[–] [email protected] 4 points 6 months ago (1 children)

The usual convention is to have extension methods behave like regular methods, I.E. don't allow them to accept nulls. When looking at foo.Bar(); it's better if I can just intuit that foo can't be null because you're not supposed to be able to invoke the . operator on null.

Of course, I'm entirely guilty of breaking this rule myself. cough Shoudly cough FluentAssertions cough

[–] [email protected] 2 points 6 months ago* (last edited 6 months ago)

I've always used the Nullable context so typically I'm just using string.IsNullOrEmpty to determine empty strings, I'm already confident null isn't leaking. But your explanation does make sense.

I'm now wondering why I've never just used myStr != ""

[–] RonSijm 4 points 6 months ago

myStr.IsNullOrEmpty() feels a bit weird to me, because you have to know that it's an extension method.

Otherwise it kinda looks like you might be trying to run a method of something that's possibly null

That's the same design principle of why ArgumentNullException.ThrowIfNull(myStr) is not an extension method