Without static type annotations you can only make best effort guesses that are sometimes right. Better than nothing but not remotely the same as actual static types. The LSP you linked works best when you use static type annotations.

Also I would really recommend Pylance over that if you can - it's much better but is also closed source unfortunately.

[–] [email protected] 2 points 8 months ago (3 children)

Why would it just be best effort? To find references for a specific thing, it still would parse an AST, find the current scope, see it's imported from some module, find other imports of the module, etc.

[–] Buttons 5 points 8 months ago* (last edited 8 months ago) (2 children)

if random() > 0.5:
    x = 2
else:
    x = "hello"

Where is the definition of x? What is the type of x? If you can't identify it, neither can the LSP.

This kind of thing actually happens when implementing interfaces, inheritance, etc. Thus, LSPs in dynamic languages are best effort both theoretically and in practice.

[–] [email protected] 1 points 8 months ago* (last edited 8 months ago) (1 children)

Look at entire file instead of snippet.
If there is anything that could create a variable x before this area, then that's where x originates. If not, and if it's a language where you can create x without using a keyword like let or var, then x is created in the scope in your snippet.

Types are not necessary at all.

[–] Buttons 2 points 8 months ago (1 children)

then x is created in the scope in your snippet

Saying "x is defined somewhere in the entire program" isn't satisfactory to many users. Also, you didn't tell me what type x has. Can I do x + 5?

[–] [email protected] 1 points 8 months ago (1 children)

That isn't what I said at all. Reread?
Find references / go to definition / rename has absolutely nothing to do with types.

[–] FizzyOrange 1 points 7 months ago (2 children)

Find references / go to definition / rename has absolutely nothing to do with types.

It absolutely does. Without static types an IDE/LSP can't reliably find all the references / definition and therefore can't refactor reliably either.

Consider something like this:

class Foo:
  bar: int

class Baz:
  bar: str

def a(f: Foo) -> int:
  return f.bar + 1

def b(f: Baz) -> str:
  return f.bar + "1"

Now imagine you want to rename Foo.bar or find all references to it. Impossible without the type annotations.

[–] [email protected] 1 points 7 months ago

Ah, I see. You're talking about object properties. I don't see any issue with finding references to variables, but for properties, yeah.

[–] [email protected] 1 points 8 months ago (1 children)

Tbf this example can be deducted as string | int just fine.

[–] [email protected] 1 points 7 months ago

The real problem is when you start using runtime reflection, like getattr(obj, "x")

[–] FizzyOrange 1 points 7 months ago (1 children)

def get_price(x):
   return x.prize

Ok imagine you are a LSP. What type is x? Is prize a typo? What auto-complete options would you return for x.?

[–] [email protected] -1 points 7 months ago (1 children)

I didn't say types. I said find references / go to definition / rename.

[–] FizzyOrange 2 points 7 months ago

How are you going to find references to prize, go to its definition or rename it without knowing what type x is? It's impossible without static types.

[–] [email protected] 1 points 7 months ago

It breaks down when you do runtime reflection, like getattr(obj, "x").