If you use git and understand that VSC's source control stuff is just a thin wrapper around git, you should understand what "discard all changes" means

[–] JackbyDev 7 points 16 hours ago* (last edited 16 hours ago) (1 children)

"discard" is not a git operation. Reset and restore are, but those weren't the words used.

[–] [email protected] -1 points 15 hours ago (1 children)

I'm not claiming that "discard" is a git action. I'm claiming a git user should understand what's meant by the phrase "discard changes". Run git status in a repo that has changes in the working directory. In the resulting output, there's a message:

Changes not staged for commit:
    (use "git add <file>..." to update what will be committed) 
    (use "git restore <file>..." to discard changes in working directory)
        ...

The phrase "discard changes" is used consistently in git's output.

[–] JackbyDev 3 points 15 hours ago (1 children)

Read this comment from the linked bug. https://github.com/microsoft/vscode/issues/32459#issuecomment-322160461

[–] [email protected] 3 points 14 hours ago

Ok that's understandable, I didn't realize VSCode used to delete untracked files as well as a result of clicking through that dialogue.

[–] [email protected] 0 points 11 hours ago

Broken stair apologism.

[–] [email protected] -3 points 17 hours ago* (last edited 17 hours ago) (1 children)

I just tried right now to get the exact message.

Are you sure you want to DELETE foo?
This is IRREVERSIBLE!
This file will be FOREVER LOST if you proceed.

The confirmation button even says Delete File...

User error.

[–] [email protected] 16 points 17 hours ago (1 children)

This issue was from 2017

[–] [email protected] 10 points 17 hours ago

Ah looking at issue 32459 it was addressed shortly after.

You're right that it did originally say "Discard".