this post was submitted on 28 May 2024
122 points (96.2% liked)

Programming

17668 readers
217 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]

founded 2 years ago
MODERATORS
snowe
Ategon
[email protected]
122
I Don't Trust My Own Code (lackofimagination.org)
submitted 6 months ago by Aijan to c/programming
37 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] -3 points 6 months ago (3 children)

I wouldn’t do that, too much tunnel vision and biases. I just skim through and make sure everything makes sense. Especially naming and comments.

[–] Kissaki 8 points 6 months ago* (last edited 6 months ago) (1 children)

I wouldn’t do that, too much tunnel vision and biases.

Absolutely not. Self-reviews are very productive. I can confirm this from my own work and my colleagues, who also find it so.

You're of course free to vary the degree and depth of self-review, but tunnel vision and bias is definitely not overbearing and diminishing in those situations for us.

Someone else will of course see more, what you may not see due to tunnel vision. But that's besides the point.

[–] [email protected] -2 points 6 months ago (2 children)

Weird, never heard of anyone doing this. Aren’t your team self reviewing the code while writing it?

[–] [email protected] 8 points 6 months ago

When you finish the final sentence of an essay or a report do you just submit it straight away? You don't read it through?

[–] Kissaki 5 points 6 months ago

How do you self-review while writing? What do you mean by that?

I see it as different phases of development, mindset, and focus. You inherently can't be in multiple at the same time.

  1. Problem space and solution exploration - an iterative and at times experimental process to find and weigh solutions
  2. Cleanup and self-review - document your findings, decision-making, exclusions, and weighing, verify your solution/changeset makes sense and is complete (to intended scope)
  3. Reviews

It makes no sense to be thorough during experimental and iterative exploration. That'd be wasted effort.

After finding a solution, and writing it out, a self-review will make you take a systematic, verifying review mindset.

[–] [email protected] 4 points 6 months ago (1 children)

I just skim through and make sure everything makes sense. Especially naming and comments.

What do you think a self review is?

[–] [email protected] 1 points 6 months ago

I think it makes sense, but only after logging out for the day and coming back to it a bit either the next day, or after a weekend in the case of code completion late Thursday or early Friday.