Indeed, it's very good. I wish he had send this before 2 Rust maintainers resigned, but I assume that he did not want to undercut Linus decisions.
robinm
I did not double check, but I assume the macro is provided by std (which is allowed to use unstable items internally). This macro can be stabilised, even if the unstable features themselves are not stabilised yet.
Nice to see continuous progress in Rust for Linux, especialy since it's seems efforts to stabilise Rust features so that RLA doesn't depend anymore on nightly seems to be fructiful.
I'm looking forward for when a big driver (like ashahi or the Nvdia one) are merged in master. It's going to be a big milestone.
I personally factorize as soon as there are two copies, but do not hesitate to inline the code and redo the abstraction when there is a 3rd use if it doesn't fit. I find it much easier to inline and re-abstact a bad abstraction, than check if two copies are indeed identical.
The exception is business logic. Usually I want all of them to be dupplicates because there is a very high chance that it's just accidental that part of the logic is similar. I take great care to have good primitives but the actual business logic that glue those primitives together is written as many time as needed.
First experience with #jj #jujitsu
I tried the equivalent of git add -p
(jj squash -i
).
- I realize that it’s closer to
git add --interactive
(which I find much more complicated and less productive) - I wasn’t able to edit a hunk (like the
e
key ingit add -p
) which I use a lot to split debug statements from real work
I generated a conflict (as I expected)
- I found no way to show the original diff
jj undo
did not worked (I have not been able to undo thejj squash
that introduced the conflict
Very not impressed so far. Fortunately it was a test repo.
Like how the average computer user is never going to [...] install Firefox or whatever.
Not right know but in 2005-2010 (or something like that), the average user was installing firefox because IE was so bad. It used to be at 80% market share IIRC.
It's really nice to see this RFC progress
I never realised it was that simple to do. Thanks a lot to answer the OP question. I had the same for longer than I wish to admit given how easy the answer was!
I think you have a hard time understanding the différence between "not possible" and "much harder".
In Rust, the code does not compile.
In C++ the code compile, but
- if you have a test case
- this test case triggers the bug (it is not guarateed to properly reproduce you production environment since it depends on the parameters of the allocator of your vector)
- you use ubsan
... then the bug will be caught.
Yes it is possible, noone says the opposite. But you can't deny it's harder. And because its harder, more bugs get past review, most notably security bugs as demonstrated again and again in many studies. The
That's why I did not said it was impossible, just order of magnitude harder to catch in C++ compared to Rust.
To have asan finding the bug, you need to have a valid unit test, that has a similar enough workload. Otherwise you may not see the bug with asan if the vector doesn't grow (and thus ref
would still be valid, not triggering UB), leading to a production-only bug.
Asan is a wonderfull tool, but you can't deny it's much harder to use and much less reliable than just running your compiler.
The issue I see is that Greg did spoke in a way that would not undermind Linux leadership. If Linux was out, I'm sure Greg would have said stuff publicly much earlier.