this post was submitted on 24 Sep 2024
5 points (100.0% liked)

C Sharp

1532 readers
2 users here now

A community about the C# programming language

Getting started

Useful resources

IDEs and code editors

Tools

Rules

Related communities

founded 1 year ago
MODERATORS
Ategon
nibblebit
Spyros
5
I think I've finally figured out nullability for required EF navigation properties (self.csharp)
submitted 1 month ago by GetOffMyLan to c/csharp
4 comments fedilink hide all child comments
 

This may be common knowledge but I've never seen it online.

[MaybeNull] public Entity Entity { get; set; }

You now get a warning when accessing without a check and when setting to null.

Sadly you still need to ! in quries

top 4 comments
sorted by: hot top controversial new old
[–] nebeker 2 points 2 days ago (1 children)

Well, you still have to ! because it may, based on the annotation, be null.

Very handy, regardless. Microsoft’s docs on these attributes are very interesting, particularly the postconditionals.

[–] GetOffMyLan 2 points 2 days ago* (last edited 2 days ago) (1 children)

But that's correct behaviour because if it isn't included in the query it is null. So you should check it and the warnings are correct.

But like you say irritating if you're doing it straight after an include haha

[–] nebeker 2 points 2 days ago (1 children)

I think .NET and EF should handle navigation property nullabiloty better out of the box, especially when you explicitly set the foreign key to long?.

That said, while I understand these relationships in my own projects, adding clear annotations is very helpful for colleagues who may have to provide support in the future. That could even be me!

So there’s no perfect solution in this stack, but anything that makes a developer’s intent clearer helps. Privilege of least surprise, right?

[–] GetOffMyLan 2 points 2 days ago

Exactly.

What we need is someone to create an analyzer that recognises when you are writing an ef query or if you've included and disabled the warnings.

The actual issue is using the same model for the database and query results. I.e. it's not nullable in the database but could be after a query. But there's no nice way to implement this without mapping everything to a dto.