Programmer Humor

19701 readers

151 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago

MODERATORS

977

Review Please (programming.dev)

submitted 8 months ago by JPDev to c/programmer_humor

112 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 26 points 7 months ago (1 children)

Or, if the team does allow refactoring as part of an unrelated PR, have clean commits that allow me to review what you did in logical steps.

If that's not how you worked on the change than you either rewrite the history to make it look like you did or you'll have to start over.

[–] [email protected] 2 points 7 months ago

Very good point. We often do one PR per story so people tend to think that's a limit.