this post was submitted on 07 Dec 2023
81 points (90.1% liked)
Programming
17668 readers
200 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities [email protected]
founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
My brain goblin is a big fan of performance. Recently I reviewed a teammate's code. It was a small 100ish line PR and he calls the same function twice in a row with a tiny variation. My brain goblin went "you could consolidate these into one call", "since it's only one call you could inline it".
A couple hours later when he came to ask me what I'm smoking I realised my proposed solution had more LoC and was more complex to read. If we needed better performance, step 1 should've been to offload this task to an API that wasn't made with python. Not to mention the next thing this API does is string manipulation and then write to file.