this post was submitted on 23 Nov 2023
124 points (97.0% liked)

Programming

17505 readers
24 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]



founded 1 year ago
MODERATORS
 

Many of us write opensource code in a void: nobody ever looks at it, uses it nor reviews it. We are the only users and authors.

In order to improve, where can we get our code reviewed? I don't mean professionally, just from like-minded individuals.

you are viewing a single comment's thread
view the rest of the comments
[–] varsock 4 points 1 year ago (6 children)

I've actually found his blog where he talks about this "optimistic merge"

http://hintjens.com/blog:106

[–] stifle867 4 points 1 year ago (5 children)

There's a number of them as the idea grows. See also the C4 process RFC

[–] onlinepersona 2 points 1 year ago (3 children)
[–] stifle867 1 points 1 year ago (1 children)

It's great to see the attempt and also an example of what the C4 guidelines are made to avoid.

Notice how many comments are little nitpicks about this and that. Completely stalling the commit and getting further away from the original point of C4 which is to reduce contributor friction and avoid these kind of endless discussions on PRs.

I don't want to be too critical because some of that is a clear lack of understanding of the motivations of C4 which is explained more thoroughly in Pieter's blog posts. You don't want to adopt a contributor guidelines that you don't understand of course.

IMO it's better just to implement it as-is and start using it in practice rather than bikeshedding.

[–] onlinepersona 2 points 1 year ago (1 children)

Feel free to make that comment there.

[–] stifle867 2 points 1 year ago

I would have but I don't want to tie my Lemmy account to my actual identity :/

load more comments (1 replies)
load more comments (2 replies)
load more comments (2 replies)