Totally fair to have gigantic PR full of boilerplate code, but generally you can split the boilerplate and your feature in 2 PRs, where only the feature will get a proper review.

All of this obviously depends on the criticality of the system :p

[–] [email protected] 10 points 2 years ago

Or split them per commit at the minimum if you don't want to create a separate PR.

[–] [email protected] 4 points 2 years ago (2 children)

That can lead to another problem though, which is that if a developer knows a merge is only part of the whole change, it becomes easy to assume any issues will be handled elsewhere.

[–] learningduck 2 points 1 year ago

How do you improve on this?

1 bigger PRs, but with multiple smaller commits, so reviews can review by commits?

[–] [email protected] 1 points 2 years ago

yeah, fair point. it really only works with standard boilerplate code which is simple enough to not have any issue I guess.. in my case working with a NX monorepo, that would be any code created using the generators