I know this implies that the reviewer didn’t care to read the bigger PR, but I think this might actually be legit. If your PR is only 10 lines long, then chances are those lines are very dense, or intricate in some other way. However, if you submit 500 lines, then it’s probably mostly boilerplate code with trivial adaptions.

No-one in their right mind would submit 500 lines of substantial code.

[–] [email protected] 33 points 2 years ago

Oh sweet summer child...

[–] nul 6 points 2 years ago* (last edited 2 years ago)

You'd be surprised. Especially if the testing environment is not readily available or if automated tests are not functional and comprehensive, large code changes can be the norm. A developer may habitually hang onto their code until a big chunk is complete, at which point it will take heaps of debugging to uncover where the errors are. This is why we need IaC to quickly create testing environments that closely mirror prod, and trunk-based development to ensure code changes are small and issues are caught as early as possible.

[–] kabat 6 points 2 years ago (2 children)

Has no one here ever worked on a new project or even a new feature in a decently sized codebase? Working exclusively in maintenance / minor change mode has to be exhausting.

[–] [email protected] 5 points 2 years ago* (last edited 2 years ago)

Depends on what you classify as “minor change”. When I took up my first professional project, I found a plethora of little things to improve which would make users happy. That was very satisfying.

On the other hand, writing yet another module that displays a list of Foos, lets the user create a Foo, show the details of Foo, update it, and delete a Foo, becomes dull quickly, despite being a “new feature”.

[–] [email protected] 1 points 1 year ago

I have worked on non-trivial (aka took 10-12 people over a year to even deliver an alpha) greenfield projects, where I literally made the first check-in into the repo.

The only 500+ line PRs I raised was auto generated boilerplate code, or renaming something.

I don't understand the optimism of devs who spend weeks writing code without bothering to test anything they've written. Unless you're writing utterly trivial BS, how does one have this level of confidence in their code? And if you did bother to stop and test, why on god's green earth would you not raise a PR? Why wait till you have thousands of lines of code before asking for feedback?

[–] [email protected] 4 points 2 years ago (1 children)

500 line of substantial code happens once in a while in my team. Goes beyond that sometimes.

[–] [email protected] 3 points 2 years ago

Saaaame, pretty frequently on my team actually