this post was submitted on 02 Jul 2023
1168 points (98.4% liked)

Programmer Humor

19819 readers
422 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] jmk1ng 50 points 2 years ago (2 children)
[–] [email protected] 49 points 2 years ago

Let’s Gamble, Try Merging!

[–] [email protected] 14 points 2 years ago (3 children)

Why. Whyyyyyy people need to comment this always? Why isn't just the Approve button enough? I so much hate it.

[–] qwop 19 points 2 years ago* (last edited 2 years ago) (2 children)

Ah, that's too boring. I have a range of responses to pick from to keep things interesting:

  • LGTM
  • Nice
  • Looks good
  • Thanks
  • Looks great
  • :thumbsup:
  • Looks good to me
  • :shipit:

For me, no text means "I haven't really reviewed this properly so don't want to write anything that could be used against me if (when?) this breaks something in prod"

[–] [email protected] 1 points 2 years ago

I reserve "ship it" to mostly trivial bug fixes.

[–] [email protected] 13 points 2 years ago (2 children)

If you're in a place with codebase analytics you want to have at least one comment on every MR - otherwise the system will start to think you're falling behind... I hate codebase analytics.

[–] IWriteDaCode 6 points 2 years ago

Analytics software like that has made my professional life so annoying at many times.

[–] GTG3000 1 points 1 year ago

In my experience, the managers get confused when issues/PRs are closed without any comment.
Useless comments beat having them pop into your slack to ask "hey, did you review this?" with a link to an approved PR.