Mostly the missing listing of clobbered registers. Other than that it's mostly just that you're doing useless things, like manually putting the stuff into the registers instead of letting the compiler do it, and the useless push and pop. And the loop is obviously not needed and would hurt performance if you do every write like that.

asm!(
"syscall",
in("rax") 1,
in("rdi") 1,
in("rsi") text_ptr,
in("rdx") text_size,

)

("so many" was inappropriate, sorry.)

[–] TadoTheRustacean 1 points 1 year ago (1 children)

I am hopeless at getting the text_ptr simpler than i64::from_str_radix(&format!("{:p}", my_string)[2..], 16).unwrap(); How can i get it the normal way?

[–] [email protected] 2 points 1 year ago

Just use str::as_ptr().

Here's an example (disclaimer: I haven't used inline asm in rust before, expect issues): https://godbolt.org/z/sczYGe96f