Java

1386 readers

1 users here now

For discussing Java, the JVM, languages that run on the JVM, and other related technologies.

founded 1 year ago

MODERATORS

Ategon

JackbyDev

thtroyer

Which order do you prefer for null testing ternary expressions? (self.java)

submitted 1 year ago by JackbyDev to c/java

15 comments fedilink hide all child comments

Which do you prefer of these two? The goal is the same. If bar is null then make foo null and avoid the exception. In other languages there is the ?. operator to help with this.

foo = bar == null ? null : bar.baz();
foo = bar != null ? bar.baz() : null;

I ask because I feel like the "English" of the first example is easier to read and has less negations so it is more straightforward, but the second one has the meat of the expression (bar.baz()) more prominently.

you are viewing a single comment's thread
view the rest of the comments

[–] MagicShel 5 points 1 year ago* (last edited 1 year ago)

I'd skip the ternary and go with

foo = Optional.ofNullable(bar)
        .map(Bar::baz)
        .orElse(null);

But if I didn't, I'd use the first form.