Java

1476 readers

1 users here now

For discussing Java, the JVM, languages that run on the JVM, and other related technologies.

founded 2 years ago

MODERATORS

Ategon

JackbyDev

thtroyer

Which order do you prefer for null testing ternary expressions? (self.java)

submitted 2 years ago by JackbyDev to c/java

15 comments fedilink hide all child comments

Which do you prefer of these two? The goal is the same. If bar is null then make foo null and avoid the exception. In other languages there is the ?. operator to help with this.

foo = bar == null ? null : bar.baz();
foo = bar != null ? bar.baz() : null;

I ask because I feel like the "English" of the first example is easier to read and has less negations so it is more straightforward, but the second one has the meat of the expression (bar.baz()) more prominently.

you are viewing a single comment's thread
view the rest of the comments

[–] o11c -2 points 2 years ago (2 children)

The second, or early return/continue/break.

But don't forget the third option:

foo = null
if (bar != null)
    foo = bar.baz();

This is much more readable if nontrivial; the only downside is that this inhibits the practice of ubiquitous final.

Actually, doesn't Java allow lazy final if you don't initialize (that would require explicit else)? I speak too many languages ...

[–] [email protected] 3 points 2 years ago* (last edited 2 years ago)

This is much less readable if non-trivial. It's easy enough here, but now I need to search through the code to see where else foo was set.

[–] JackbyDev 1 points 2 years ago

Yes, Java allows lazy final like you say. I also prefer full blown if when it is non trivial or longer than a full line. (Wish we had if-expressions!)