this post was submitted on 27 Sep 2023
50 points (68.7% liked)

Programming

17669 readers
166 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]



founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[โ€“] cmeerw 25 points 1 year ago* (last edited 1 year ago) (1 children)

Did a bit more digging through the mailing list (also looking through the links posted on the HN thread), and to me it looks a bit weird.

OP came up with an initial patch (Wed, Jun 1, 2022 at 12:36 PM) that wasn't deemed to be good enough to be merged. Maintainer came up with a different patch (Tue, 7 Jun 2022 00:34:56 +1000) saying "but I wanted to fix it differently". OP then posted a reworked patch (Fri Jun 10 17:15:49 AEST 2022) that looks a lot more similar to the maintainer's patch.

The maintainer's patch and OP's reworked patch look quite similar, but from what I can see from the mailing list, the maintainer actually came up with that approach, and OP didn't then credit the maintainer in his reworked patch. @[email protected] can you please clarify, what am I missing?

[โ€“] kairos 3 points 1 year ago

Between the initial patch and the maintainer's patch there was a private conversation between me and the maintainer (I don't have access to it because I've used my work email and since then I switched companies). I posted my reworked patch only for visibility, since by then they have accepted the maintainer's patch. But I sent the reworked patch in private to the PowerPC maintainer, before sending it to the powerpc mailing list.