Maybe there’s more implementation nuance here but it seems like an opinionated rule that has zero effect on performance unless that code is being called thousands of times every second

It's good practice to get in the habit of coding to only do the things you want/need to do rather than hoping the compiler does it for you.

This particular constructor call may be light, but there may be constructors that have a lot of overhead. Or you might be running alongside 1000 other processes who said the same thing and you start to see performance degradation.

[–] [email protected] 3 points 3 weeks ago (1 children)

These things add up if you're doing them all over a 1 million line codebase, by which point it's incredibly painful to claw back performance if you need it.

[–] ulterno 4 points 3 weeks ago* (last edited 3 weeks ago)

This seems like one of those cases where you don't want to be waiting until benchmarking.

It makes the code simpler anyway.