this post was submitted on 20 Nov 2024
923 points (97.6% liked)

Programmer Humor

19746 readers
410 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS
923
submitted 1 week ago* (last edited 1 week ago) by [email protected] to c/programmer_humor
you are viewing a single comment's thread
view the rest of the comments
[–] BatmanAoD 20 points 1 week ago (12 children)

It had a reasonably clear warning, though; a screenshot is included in this response from the devs. But note that the response also links to another issue where some bikeshedding on the warning occurred and the warning was ultimately improved.

[–] [email protected] 14 points 1 week ago (6 children)

I disagree that that warning is reasonably clear. Even the comment that included it has the line of thought, where the user, not knowing what terms git uses thinks that they just did an action that is going to change each of their files. It makes sense that they'd want to discard those changes. That user then goes on with some snark about not wanting to learn any more about what they are playing with and that other programs would do the same, but "discard changes" seems like it would have a clear meaning to someone who doesn't know git.

The warning says it isn't undoable but also doesn't clarify that the files themselves are the changes. Should probably have a special case for if someone hits discard changes on a brand new repository with no files ever checked in and hits discard on a large number of files instead of checking them in. Even a "(This deletes all of the local files!)" would make it clear enough to say what the warning is really about.

[–] [email protected] 8 points 1 week ago (1 children)

Even if you know git, you wouldn't assume that "discard all changes" affects untracked files. It's bad design all around

[–] BatmanAoD 1 points 1 week ago

That depends on what you map "discard" to in your mental model. Whoever designed the VSCode feature chose to associate it with reset+clean, rather than just reset. Presumably that's why they called the menu option "discard" rather than "reset". (But I agree that this is a surprising choice, and that they managed to make an already-famously-bad UX even worse.)

load more comments (4 replies)
load more comments (9 replies)