Got will not delete untracked files though, which is what happened here. If you want to discard changes to a file with git, you first have to commit the file to the index at some point, which means there's only ever so much damage an erroneous "git restore" or "git reset" can do. Specifically, neither of them will delete all the files in an existing project where VC has just been added.

[–] [email protected] 7 points 1 month ago (2 children)

This user was not using git though, he was using vs code. That button doesn't say "git reset" it says "discard all changes". And btw, what it does is "git clean", which is something that git can do.

Just below the button there is a list of all the changes. In his case, there were 3000 changes of the type "file creation". Discarding a file creation can only be made one way: deleting the file.

Anyway, this user is presumably in his learning phase, I would not assume that he knows what git reset or git restore actually do.

[–] [email protected] 6 points 1 month ago

In other IDEs this discards tracked changes, untracked files usually stay untouched.

In my opinion, it's a combination of user error and bad implementation here

[–] [email protected] 2 points 1 month ago

Fair enough, git clean does exist. However, if the button saying "discard all changes" is really a button that runs git clean, that's just a plain terrible design choice. git clean is "delete all untracked files", which is specifically not discarding changes, because there can be no changes to discard on an untracked file. Even talking about "changes" to an untracked file in VC context makes little sense, because the VC system doesn't know anything about any changes to the file, only whether it exists or not.

That's not even mentioning the fact that the option to "git clean" shows up as one of the easily accessible options in relation to a staging process. Especially if you're coming from the git CLI, you're likely to associate "discard changes" with "git restore".

[–] [email protected] 2 points 1 month ago (1 children)

Mein Gott!

[–] [email protected] 2 points 1 month ago

Yeah, I guess I've got to leave it like that now..