I don't know anything about programming, i came here from /all, but it seems to me that a command that's this permanently destructive warrants a second confirmation dialog message reminding the user that the files will be permanently deleted and not undoable

[–] [email protected] 59 points 3 days ago* (last edited 3 days ago) (23 children)

Here is the exact warning that a user had to click through in order to get to where they got:

The warning

[–] [email protected] 89 points 3 days ago (3 children)

That's not a very good dialog box. He didn't make any changes, so discarding them doesn't sound like a problem.

There should be a notice when you enable source control that this will permanently delete all existing files with a checkbox (checked by default) that says "Add existing files to source control."

[–] Pyro 10 points 3 days ago* (last edited 3 days ago) (1 children)

~~He wouldn't have seen the "Discard Changes" button at all if source control wasn't already setup (and detected by VSCode).~~

~~No sane program will delete files when you initialize source control either.~~

As I found later, VSCode did have weird behaviors with source control back then. My experience is more with the latest versions.

[–] [email protected] 12 points 3 days ago (1 children)

My sibling ran into this issue once. I'm not sure if it's a setting or a default, but vscode would assume they were working in a blank repo until they made a commit.

Sounds like this person had the project (without source control) in another IDE, tried out VSCode, and it assumed that it was all 'changes'. I don't use VSCode, do I can't say for certain, but I know my sibling lost ~4 hours of project set up for the same reason (though they immediately realized it was their fault).

[–] Pyro 9 points 3 days ago

Reading your comment and #32459, I realize that VSCode source control did have some major issues back then.

It looks like they have improved though, as the latest VSCode I use doesn't auto-initialize repositories anymore.

load more comments (1 replies)

load more comments (20 replies)

load more comments (34 replies)