Honestly refactoring everything isn't an "improvement." More often than not it's a sign of that developer not understanding what the code does. Which is fine if they need to do that in a new code base or are otherwise rather green. Writing code is easier than reading it, after all. However they really should stash those changes or reopen a new branch after that exploratory phase.

IMO (in general) a good bug fix makes the smallest possible change to implement said fix. Otherwise the focus is about documention of the bug if needed and some minor refactoring to improve readability, consistency, or efficency

[–] [email protected] 14 points 1 year ago* (last edited 1 year ago) (1 children)

I like the approach of when finding a bug, write a test to reproduce it, fix the bug so the test passes, next do whatever refactoring you want because you have a test passing :)

[–] [email protected] 2 points 1 year ago

This sounds like a great technique. I'll have to give it a go on Monday haha

[–] kSPvhmTOlwvMd7Y7E 1 points 1 year ago* (last edited 1 year ago)

Unfortunately sometimes the code base is fuckd up beyond repair, it can't even be tested. that's why i submitted 3000 line PR ☠️