I haven't gone through it thoroughly but the first thing that stuck out was the use of a default logger. I don't think libraries should log by default. If you do allow a logger to be injected in I think it should be an interface.
this post was submitted on 02 Mar 2025
8 points (100.0% liked)
Golang
2322 readers
1 users here now
This is a community dedicated to the go programming language.
Useful Links:
Rules:
- Posts must be relevant to Go
- No NSFW content
- No hate speech, bigotry, etc
- Try to keep discussions on topic
- No spam of tools/companies/advertisements
- It’s OK to post your own stuff part of the time, but the primary use of the community should not be self-promotion.
founded 2 years ago
MODERATORS
I don't think libraries should log by default
That's a fair point, interfaces are still a concept that boggle my mind a bit, but maybe this is the problem that will help me actually grasp them. Thanks!
I haven't written go in a little while, so things may have a changed since. I'll give this a go regardless.
First thing I notice is there's no explanation of what this is supposed to do. A little blurb in the readme would help. I have no idea what rbac is, so it would give me some context.
Then, there's no main function. Where's the entry point? This is a bit where I'm doubting myself now. Maybe go has changed, but when I was writing it, it requires a main function to even run.
I also notice that many of your functions and types start with a capital letter, making them public, but everything is in the same package. This is maybe nitpicky, but I would start with everything as private. As the project grows, and things get organised in packages, you open up the things you need.
With all that said, if it runs and does what you expect it to, I'd say that looks good!
there’s no explanation of what this is supposed to do.
Totally right, sorry about that, I'll update the Github, but it brief this is a library that's supposed to help a developer set up a Role Based Access Control system for an API for web service. Role Based Access Control is a method of access control whereby (And this is my very beginner's understanding of it) users are assigned roles, and these roles are in turn issued different permissions based off what that role is supposed to have access to. When checking if a user is authorized access to a certain resource, the roles assigned to them are checked for the permissions needed for the resource. If they have permission then they are granted access to the resource, otherwise they are denied access.
This library manages roles, permissions assigned to roles, and checking of permissions against roles via an http middleware.
Then, there’s no main function. Where’s the entry point? This is a bit where I’m doubting myself now. Maybe go has changed, but when I was writing it, it requires a main function to even run.
Well, this is supposed to be a library that's used by other people, so it has no main function itself, rather it's called by other people
Since it has no main, I guess it's not an executable but meant as a library, which also explains the exports, as a third party should be able to consume the library
That's a bingo! Yeah I decided to dip my toes into Go by writing a simple library on a topic I was learning about