Golang

2322 readers

1 users here now

This is a community dedicated to the go programming language.

Useful Links:

Rules:

Posts must be relevant to Go
No NSFW content
No hate speech, bigotry, etc
Try to keep discussions on topic
No spam of tools/companies/advertisements
It’s OK to post your own stuff part of the time, but the primary use of the community should not be self-promotion.

founded 2 years ago

MODERATORS

Ategon

RandomDevOpsDude

austin

Are code reviews allowed? I wrote a pretty basic RBAC module while working on a separate learning project and was hoping to get the opinion of more experienced Gophers (github.com)

submitted 2 days ago* (last edited 1 day ago) by [email protected] to c/golang

6 comments fedilink hide all child comments

It appears to pass all tests, but I'm not sure if my test writing skills are necessarily that great, I semi-followed the learn go with tests eBook. I appreciate any feedback, and if this isn't an appropriate post for this community just let me know and I'll remove.

Thanks!!

*** Update *** Updated the repository to be a bit more discriptive of what the library is for and added in a small example project of it in action.

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 2 points 1 day ago (1 children)

I haven't gone through it thoroughly but the first thing that stuck out was the use of a default logger. I don't think libraries should log by default. If you do allow a logger to be injected in I think it should be an interface.

[–] [email protected] 2 points 1 day ago

I don't think libraries should log by default

That's a fair point, interfaces are still a concept that boggle my mind a bit, but maybe this is the problem that will help me actually grasp them. Thanks!