Keep changes small, we use git patch stack https://github.com/uptech/git-ps
this post was submitted on 29 Mar 2024
976 points (98.3% liked)
Programmer Humor
19187 readers
1114 users here now
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
founded 1 year ago
MODERATORS
Human made changes is likely not what caused this image to occur.
111 files with that kind of change count is most likely a dependency update. But could also be that somebody screwed up a merge step somewhere.
The only way I see that is a dependency update is if you're versioning your node_modules or which is generally a no-no
load more comments
(1 replies)
Or maybe their IDE had a different auto indent config and they saved it all, then committed it all without checking the diff or the status.
You should have an agreed upon format that is enforced by cicd. Prettier, black, whatever.
load more comments
(1 replies)
load more comments
(3 replies)
I'm still annoyed that Github doesn't have good support for stacked diffs. It's still not possible to say that one PR depends on a different one, and still has no ability to review and land them as a stack.
Love it when my coworkers reformat the code style, making it nigh impossible to understand what they actually changed, while greatly inflating their “contribution.”
It also blows away the git blame, making it hard to know who actually changed that one critical line of business logic 3 years ago that you need to understand before trying to fix some obscure bug.
I have one coworker who does this constantly and if you just looked at git blame, you’d think he wrote the entire code base himself.
First things first: Your team needs a coding style.
Also: With git reflog ignore-revs you can filter commits that only adapt the style.
And while we're at it, check out the -C -C -C flag for git blame. https://git-scm.com/docs/git-blame#Documentation/git-blame.txt--Cltnumgt
Just one review request?