Programming Horror

1891 readers

1 users here now

Welcome to Programming Horror!

This is a place to share strange or terrible code you come across.

For more general memes about programming there's also Programmer Humor.

Looking for mods. If youre interested in moderating the community feel free to dm @[email protected]

Rules

Keep content in english
No advertisements (this includes both code in advertisements and advertisement in posts)
No generated code (a person has to have made it)

Credits

Icon base made by Lorc under CC BY 3.0 with modifications to add a gradient

founded 1 year ago

MODERATORS

Vacant

Who needs a commit message, anyway? (github.com)

submitted 10 months ago by [email protected] to c/programming_horror

27 comments fedilink hide all child comments

I was looking through various RCON tools and found this. Someone does not like commit messages.

you are viewing a single comment's thread
view the rest of the comments

[–] Mikina 5 points 10 months ago (1 children)

Well, the first step is to not be an elitist gatekeeper who scares away any beginner who tries to develop open source stuff. Because even if their first few repositories were not exactly good, they may eventually get better, and if their experience with FOSS community was a pleasant one, there is a pretty high chance they will publish their later work too.

If, on the other hand, you publicly shame every mistake a beginner makes in hist first repository, they will probably never publish anything.

It's important to praise anyone who's self-less enough to write FOSS. Even if they aren't exactly good yet, just the fact that they have decided to publish it is really important. I'm not saying that we shouldn't offer any negative feedback - quite the contrary - but the feedback definitely shouldn't be public shaming in a meme post on random social network.

[–] [email protected] 3 points 10 months ago

Yeah for sure don't shame them. But also, don't merge code that is bad. Opensource needs standards too because at the end of the day it's competing with closed source. Even if it's a first contribution, you probably shouldn't merge things without tests, without commit messages, etc