Experienced Devs

4049 readers

1 users here now

A community for discussion amongst professional software developers.

Posts should be relevant to those well into their careers.

For those looking to break into the industry, are hustling for their first job, or have just started their career and are looking for advice, check out:

Logo base by Delapouite under CC BY 3.0 with modifications to add a gradient

founded 2 years ago

MODERATORS

snowe

jmk1ng

drewsiferr

While reviewing a PR, you find some piece of code that seems to work perfectly well, but some functions are written in a style that you don't particularly favor. What do you do? (cupid.careers)

submitted 2 weeks ago by [email protected] to c/experienced_devs

17 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] Maddier1993 1 points 1 day ago

I would like to add to the other excellent points on when to avoid pressing the matter.

If the person has multiple reviewers, and the review itself is far along enough that most of the complex comments are fixed then it is quite irritating having new comments that focus on style.

Giving a comment on style is to be avoided late into the review. Some reviews even have very long running CI/CD that reruns on every commit and won't accept older results. If it makes the assignee wait for even 4 more hours it's not worth it to give such comments after everything else.