this post was submitted on 26 Jul 2023
11 points (100.0% liked)
Photon
2 readers
8 users here now
The community for the Photon Lemmy client.
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
I've been working on fixing spoilers but because they aren't part of the official markdown standard it's kinda hard. I'm trying to figure out how to add my own markdown elements in markdown-it.
How would I show all the different sort options without it looking bad? Should I do a drop-down for if you've selected "top"?
Ah, I didn't realize spoiler tags were non- standard.
I agree, drop down from Top sounds like the best option. The same idea could also work for New: show a drop down menu to sort by either New Posts or New Comments.
Photon is quickly turning into my favorite way to browse Lemmy!
You're a far better programmer than I am, and I don't know the codebase well, but could you use some of the code from https://github.com/LemmyNet/lemmy-ui/blob/main/src/shared/markdown.ts and implement it into https://github.com/Xyphyn/photon/blob/main/src/lib/components/markdown/markdown.ts ? The licenses seem compatible, though I don't know how the mix of Svelte and TypeScript of Photon will affect things.
Since lemmy-ui and Photon both use markdown-it, this is certainly possible. I can implement all of the awaited markdown features now!
Great! Thank you, and I'm glad I could help.
Spoiler support was added!
Example
woooooo, this works as of v0.4.1Thank you! You are insanely fast. Photon is definitely my favorite frontend already, and it's constantly improving.