def create
  unless admin redirect_to new_session_path and return
  
  @product = Product.new product_params

  if @product.save
    flash[:success] = "New product has been created!"
    redirect_to edit_product_path(@product) and return
  else
    flash[:error] = "Something went wrong!
    render :new
  end
end

This is working code that I simplified a bit from an old project of mine.

[–] [email protected] 12 points 3 months ago (5 children)

Ruby syntax is nice although I prefer python way of enforcing indentation instead of adding "end"s. Personally I just want a statically typed language with enforced indent as syntax.

[–] [email protected] 7 points 3 months ago (3 children)

Funny, the forced indentation is what I hate about Python. If you think a missing semicolon can be hard to catch, don't ever think about a missing whitespace :p

The end keyword really isn't a big deal for me. I find it to be a good way to easily spot the end of a method. But if you wouldn't like it I'd still find it a good compromise to avoid syntax issues due to whitespace.

[–] [email protected] 5 points 3 months ago (1 children)

i can count on one hand how many times ive had white space issues in 15 years of using python. its just not an issue

[–] [email protected] 3 points 3 months ago

Same and agreed, especially if you keep your functions small and focused as you should. 3-5 indents is nbd to keep track of, and if you need more than that... No you don't, refactor.

I've had way more hangups with brackets then indentation, personally, not that either is a super frequent issue, but I'm indenting anyway, so brackets are redundant and just another thing I have to keep track of

load more comments (1 replies)

load more comments (2 replies)

load more comments (3 replies)