this post was submitted on 26 Jul 2024
214 points (95.3% liked)
Technology
57906 readers
5198 users here now
This is a most excellent place for technology news and articles.
Our Rules
- Follow the lemmy.world rules.
- Only tech related content.
- Be excellent to each another!
- Mod approved content bots can post up to 10 articles per day.
- Threads asking for personal tech support may be deleted.
- Politics threads may be removed.
- No memes allowed as posts, OK to post as comments.
- Only approved bots from the list below, to ask if your bot can be added please contact us.
- Check for duplicates before posting, duplicates may be removed
Approved Bots
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
This is not a GitHub issue. It's a GIT feature. People are always going to clone your repo.
Well, sort of. GitHub certainly could refuse to render orphan commits. They pop up a banner saying so but I don't see why they should show the commit at all. They could still keep the data until it's garbage collected since a user might re-upload the commit in a new branch.
This seems like a non-issue though since someone who hasn't already seen the disclosed information would need to somehow determine the hash of the deleted commit.
Ah - Actually reading the article reveals why this is actually an issue:
So enumerating all the orphan commits wouldn't be that hard.
In any case if a secret has been publicly disclosed, you should always assume it's still out there. For sure, rotate your keys.
Forks do not exist in git. It's a GitHub feature, and a massive blunder at the same time.
Yes they exist. It's called a clone
The article is specifically about how GitHub forks are not the same as a git clone. A clone isn’t accessible from the upstream without the upstream pulling the changes, but this vulnerability points out that a fork on GitHub is accessible from the upstream without a pull, even if the fork is private.
It’s because GitHub under the hood doesn’t actually do a real clone so that they can save on disk usage.
You actually can't turn a fork private on github
How can such a wrong answer get so many points? Clones and forge forks are unrelated. First, GitHub or GitLab cannot and could not link clones together without analyzing the remotes of each clone.
FFS it's a tech community...
Because you are the one being wrong. Github and others only provide a nice interface around clones. That's all there is, and it doesn't matter much