this post was submitted on 22 Jun 2024
21 points (95.7% liked)
Rust
6025 readers
1 users here now
Welcome to the Rust community! This is a place to discuss about the Rust programming language.
Wormhole
Credits
- The icon is a modified version of the official rust logo (changing the colors to a gradient and black background)
founded 1 year ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Since this is library code, why not make the function return a
Result
?Yup, libraries should usually let the consumer chose what to do with an error, not crash the program without a choice in the matter. The only real exception is performance critical low level code such as the core of a graphics or audio driver. Though in those cases crashing also often isn't an option, you just power through and hope things aren't too screwed up.
Thanks for the tip! Updated
The new version seems to fix that since your comment was written, but it will stil panics if less than 2 samples are provided, unless the crate it wraps panics at an earlier point.
You should have mentioned OP.
@fil
Excellent catch! Added validation for the
new
params