this post was submitted on 25 Jun 2023
26 points (100.0% liked)

Programming

13376 readers
2 users here now

All things programming and coding related. Subcommunity of Technology.


This community's icon was made by Aaron Schneider, under the CC-BY-NC-SA 4.0 license.

founded 2 years ago
MODERATORS
 

cross-posted from: https://programming.dev/post/214031

Have you ever used git bisect? If so, how did you use it? Did it help you find a problem which would otherwise be difficult to find? Story time, I guess?

top 19 comments
sorted by: hot top controversial new old
[–] [email protected] 9 points 1 year ago* (last edited 1 year ago) (2 children)

Multiple times.

Typically on high frequented repositories. If there are a hundred commits (or more) each day, suddenly merged from multiple branches and shit starts to go weird, it is sometimes not clear when exactly it started to go south. So I write a test to reproduce the problem and then let git bisect checkout, run test, etc. until it can tell me which revision it first occurred in.

One time I also had to find out when a specific functionality in a microcontroller broke. I have forgotten, why we knew it worked before without having it covered in a test, though. The build-download-testrun-repeat-cycle took almost a day until it could pinpoint the revision. That was fun. But it nailed it to a single line and was right with it.

[–] [email protected] 3 points 1 year ago

This exactly. The more developers working on different parts of an application, the more chance of an apparently-easy merge having unforeseen side effects. git bisect is the easiest way to narrow down the problem so real debugging can begin.

[–] canpolat 3 points 1 year ago

This is how I used it too. Write a test that fails with the "bad" version. Use a script to cherry-pick and run the test. It's fun to watch it find the first bad commit even though what git bisect does is quite simple.

[–] vilcans 5 points 1 year ago

I use it from time to time. Often I test manually instead of automatic, and it often works very well.

But if you want a story about an unconventional use of git bisect, I think there's one about the time I had a directory with lots of files, and one of those files was causing some problem, but I didn't know which one it was. Those files were not under version control, but I created a repo with them, where each file was added in a separate commit. Then I could use git bisect to find which file was causing the problems.

[–] [email protected] 4 points 1 year ago

I've used it only once to find a bug in a section of code at a company I was working for that both me and the other engineer I was working with did not know the history of. We were able to triangulate effectively the root of the pre-existing bug, and kind of how it was introduced, because of the surrounding history. Very useful tool for this purpose, albeit one that I use very infrequently.

[–] [email protected] 4 points 1 year ago

Several times, sometimes to find out when an incompatibility was introduced in an upstream dependency to find the maximum compatible version, but usually to find the commit that introduced a strange bug.

The process is always the same... Write a unit test, start bisect, check test select next bisect step, repeat. If your last-known-good and first-known-bad are correct, it always worked for me.

[–] [email protected] 3 points 1 year ago

I've used it to fix regressions, most recently in a register allocator for a compiler. There's pretty much no chance I would've found that particular bug otherwise; it was caused by an innocuous change (one of those "this shouldn't matter" things) clashing badly with an incorrect assumption baked into a completely different part of the allocator.

I had seen the same effect from an unrelated bug on a different program. When I added a new test and saw the same effect, I had a "didn't I fix this already?" moment. When I saw that the previous fix was still there, I checked if an older version of the allocator exhibited the same bug on the new test, and it did not. Bisecting found the offending change relatively quickly and further conventional testing exposed the incorrect assumption.

[–] [email protected] 3 points 1 year ago

I've done the exact same process by hand, good to know there's a way to automate it (to an extent)

[–] [email protected] 3 points 1 year ago

Yes, once. Our research lab's in-house software suddenly started throwing segfaults. The update was from the Mac side (OS), not the software side, so it would've been near impossible to figure out exactly which feature of the software no longer played nice with the new MacOS. We (me and a mentor) used git bisect to figure out what feature didn't work, and patched it for the new OS update.

The next week I went and bought a new laptop and installed Linux on it so that didn't happen again.

[–] [email protected] 3 points 1 year ago* (last edited 1 year ago)

Yes, back in 2009, after a kernel update to 2.6.26 there was an intermittent and hard to reproduce problem with Intel's e1000e ethernet linux kernel module. It only happened when some specific switches/hubs were connected to the interface; the interface would initialize in an unusable state (about 50% of the computer boots).

The e1000e module was used by a lot of Intel onboard ethernet interfaces, including the one used by Dell Vostro computers.

I found other people reporting it in the kernel's bugzilla, and added my case.

The Intel developer couldn't reproduce it (he didn't have one of the switches that triggered the problem), so he asked me to use bisect to help narrowing down to the commit that started the problem.

Because it was an intermittent issue, I wrote a script to reboot the PC multiple times on each bisect try, to eliminate false positives.

(I didn't remember all these details, but googled my name and bisect, and found the bugzilla thread; it's an interesting bisect use case: https://bugzilla.kernel.org/show_bug.cgi?id=11998#c8 - no I don't mind this associates my lemmy user name with my real name).

The bisect did locate the culprit commit, and after many other tests, it ended up being an issue with the MDI/MDIX (crossover or straight connection detection). The correction was pushed into the kernel.

Bisect definitely helped to find an important and otherwise difficult to find problem there.

[–] [email protected] 2 points 1 year ago* (last edited 1 year ago) (1 children)

Can't remember details, so no particularly interesting story around it I guess. Just a couple of times when something had broken at an unknown point in time and I needed to figure out which commit. I've been using git almost since its inception, and in a work setting since maybe 2010. And in that time, I've used git-bisect maybe ten times. While that might make it sound like a useless feature, it is a life saver when you do need it.

[–] canpolat 2 points 1 year ago

Exactly. Even though one doesn't need it often, it's an important tool.

[–] [email protected] 2 points 1 year ago

4-5 times now. When confronted with more than a hundred commits between latest known working version and the one you’ve observed the bug (which was not catched by any of the unit tests) it can save some time to find the fishy commit.

In such a case I create a testcase on top to reproduce the bug. Then bisect and for each stage add the testcase, build, run tests. FYI: this only works if all (or at least most) of the commits in the chain are compilable - if you’ve done a big messy refactoring with several commits breaking the build, bisect can get you only so far.

https://feddit.de/comment/527050

[–] [email protected] 2 points 1 year ago

Have you ever used git bisect?

Yup. A few times a year.

If so, how did you use it? Did it help you find a problem which would otherwise be difficult to find?

It helps me track down regressions, as in “this used to work, didn’t it?” or worse “haven’t I fixed this before?”.

I start a bisect, pick something relatively old, check if it works there, rinse, repeat.

[–] [email protected] 2 points 1 year ago

A lot of times. It doesn't really help to find a problem, but rather when the problem was introduced. It's a really great tool.

[–] o_o 2 points 1 year ago

Yeah, a few times. It was especially helpful in finding causes of subtle UI bugs, to identify the exact commit which changed the UI.

[–] [email protected] 1 points 1 year ago* (last edited 1 year ago)

Yes. Two or three times in 15 years.

It did help me locate issue introduction. The thing it's for.

load more comments
view more: next ›