this post was submitted on 01 Mar 2024

6 points (100.0% liked)

Thunder App

2777 readers

1 users here now

An open-source, cross-platform Lemmy client for iOS and Android.

This community is intended to discuss features and feature suggestions for Thunder; as well as friendly, respectful talks about Lemmy in general.

Please use the GitHub repository linked below to submit bug reports, so keeping track of them is easier, and make sure to search first if you already can find an issue for your report.

If there are any developers who would like to contribute, feel free to reach out on GitHub!

General Links
Website: Link
GitHub Repository: Link
Matrix Space: Link

Android Releases
IzzyOnDroid: Link
Google Play: Link

iOS Releases
Apple App Store: Link
TestFlight Beta: Link

Related Communities
Nightly Community: Link

founded 1 year ago

MODERATORS

[email protected]

micahmo

Space after ::: in spoiler (self.thunder_app)

submitted 8 months ago by sukhmel to c/[email protected]

5 comments fedilink hide all child comments

It seems that the web UI treats spoilers without a space after ::: the same as the regular ones, while Thunder ignores those as spoilers. It looks like the closing spoiler marker may be entered without whitespace but it consumes extra text after the spoiler, and overall acts weird

I can create an issue if that's needed, or this post may be referenced in an existing issue to be used as a test

no whitespace
Content



whitespace present
Content



one-liner no whitespace
Content

one-liner whitespace present 
Content

Extra text in the end

one-liner whitespace present Content


Second extra text

produces

no whitespace

Content

whitespace present

Content

one-liner no whitespace

Content

one-liner whitespace present

Content

Extra text in the end

one-liner whitespace present

Content

Second extra text

top 5 comments

sorted by: hot top controversial new old

[–] sukhmel 2 points 8 months ago (1 children)

To be fair, the last three spoilers become parts of each other in the web UI, so maybe it's ok that those act weird in Thunder, too

one-liner without newline
Content

Text A

one-liner without `:::`Content

Text B

 spoiler one-liner with newline
Content
:::

Text C

Produces

one-liner without newline

Content

Text A

one-liner without :::

Content

Text B

spoiler one-liner with newline Content :::

Text C

[–] sukhmel 1 points 8 months ago

Also, I can't seem to find a definition of format, as it looks like a spoiler may go completely without closing ::: but can't check it against the standard

[–] [email protected] 2 points 8 months ago (2 children)

Thanks for the feedback! It would be awesome if you could create a new GitHub issue on this so that it makes it easier to keep track of.

Just as you mentioned, there doesn't seem to be a definition for what correctly defines a spoiler tag in Lemmy, so it's a bit difficult to get all the edge cases right! I kept the parsing to be limited to what Lemmy UI produces when you press the spoiler tag (which adds a space after :::). This is also non-standard markdown which makes it particularly more difficult to implement 😅

For reference, this is what Lemmy UI generates as a template:

spoiler___

[–] sukhmel 3 points 8 months ago

I've filed an issue. I tried to be clear and concise but not sure if I did a good job at that.

All in all, it seems like there needs to be a post with all the possible combinations of weird stuff (e.g. using tabs as whitespace, not having closing ::: etc) and some interaction with lemmy-ui dev to understand if that cases are treated correctly by them and what is an intended way

[–] sukhmel 1 points 8 months ago

Yeah, I remember the tracking issue with a discussion of this feature

I will create an issue soon and post back