C++

1761 readers

1 users here now

The center for all discussion and news regarding C++.

Rules

Respect instance rules.
Don't be a jerk.
Please keep all posts related to C++.

founded 1 year ago

MODERATORS

lysdexic

[email protected]

Nihili0

How to avoid one C++ foot gun (pboyd.io)

submitted 5 months ago by lysdexic to c/cpp

15 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] cmeerw 9 points 5 months ago (2 children)

And even the presented fix hurts my eyes. Should have used a unique_ptr or optional.

[–] [email protected] 3 points 5 months ago

Exactly, raw pointers are very rarely the way to go

[–] lysdexic 1 points 5 months ago* (last edited 5 months ago) (1 children)

You'd be missing the whole point too if you think that the pointer is the root cause. The problem is that the class is not designed to be copy-able, let alone moveable. Your suggestion to use a unique_ptr will also blow up in your face the moment you try to copy an instance.

[–] cmeerw 2 points 5 months ago (1 children)

Depends on what semantic you want. Sure, if you use a unique_ptr member, you will get a deleted copy constructor/operator - I wouldn't consider that blowing up in my face.