this post was submitted on 11 Apr 2024
28 points (93.8% liked)

C++

1775 readers
1 users here now

The center for all discussion and news regarding C++.

Rules

founded 1 year ago
MODERATORS
lysdexic
[email protected]
Nihili0
28
How not to check array size in C++ (pvs-studio.com)
submitted 7 months ago by lysdexic to c/cpp
8 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] lysdexic 5 points 7 months ago (1 children)

Why no mention of std::array?

I think this was focused on maintaining code. Replacing C-style arrays with std::array can be a daunting task, depending on how the project is structured.

[–] [email protected] 1 points 7 months ago* (last edited 7 months ago) (1 children)

I don't really see how it's daunting enough to avoid mentioning. You can replace a C array on the stack by just swapping it with std::array. Yes, it can depend on the project structure, but that's equivalently true for any STL container the author recommended.

[–] lysdexic 3 points 7 months ago (1 children)

I don’t really see how it’s daunting enough to avoid mentioning.

I think it's a good call not to mention them because they are irrelevant given the topic. If your code base and/or the consumers of your code base are using C-style arrays for input and/or output, it's hardly helpful to suggest changing all your interfaces to use another data type. It's outright impossible if you're dealing with extern C interfaces.

[–] [email protected] 2 points 7 months ago (1 children)

Depending on what OP is trying to do; swapping out the internal implementation with array and then decaying to the old terrible .data() 'pointer that could be anything' when having to cross interfaces and boundaries could be a winner. At least their own stuff gets the benefits of known size, bounds checking and being a real class, and the code improvements can be done a little at a time. I'd almost consider this the main use case for array - unless for some reason you just absolutely must allocate on the stack, then vector is better in every way.

Same argument for smart pointers. If some legacy code returns an owning pointer, then get it wrapped up as soon as possible. At least your own code won't leak.