this post was submitted on 04 Jul 2023
394 points (97.8% liked)

Programmer Humor

32567 readers
316 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 11 points 1 year ago (3 children)

Is it a lemmy issue or a jerboa issue?

[–] [email protected] 34 points 1 year ago (4 children)

Serious Answer: This is a Jerboa issue. Lemmy is written in Rust. The error message is a Java error which is what native Android apps use.

[–] [email protected] 16 points 1 year ago (2 children)

I think it's both, actually. Lemmy is often giving html where json is expected, and Jerboa isn't handling the error well.

[–] [email protected] 17 points 1 year ago

🤔 The server spits out html when it cannot reach the backend. So one could argue it's a configuration issue because the admin didn't provide enough capacity / didn't set up a proper generic json error for backend failures.

FWIW, Liftoff doesn't handle these super gracefully either.

At any rate I think it's kinda awesome that we get to witness these kinds of infancy problems.

[–] [email protected] 2 points 1 year ago (2 children)

Well, what should Jerboa do? Pretend it received content?

[–] [email protected] 18 points 1 year ago

It should display a human-readable error message instead of the raw one.

[–] [email protected] 17 points 1 year ago

Take it as an error, tell the user about it and then retry with exponential back-off.

[–] [email protected] 7 points 1 year ago (1 children)

No, it's probably when the app is expecting a json but the server returns an html, which usually happens in case of 502 errors.

[–] [email protected] 1 points 1 year ago* (last edited 1 year ago)

You really shouldn't be expecting any content type when you get any code but a 200. If anything you should expect HTML, then, possibly plain text.

[–] [email protected] 2 points 1 year ago

If it's Jerboa/Android app issue, why do I get JSON errors using Lemmy on my desktop PC with Firefox? Forgive me if this is a dumb question, I have very little programming knowledge.

[–] [email protected] 1 points 1 year ago (1 children)

No, this is a lemmy issue. The API specification specifies a JSON response, and the server randomly provides HTML, this is a bug in the server. I agree that Jebora should retry in the case of a network failure (timeout, 4xx staus codes...) but it should not have to retry in a case of a server that is not folowing the standard.

[–] [email protected] 1 points 1 year ago

lemmy does not return 502 error codes because 502 means "bad gateway" and lemmy is not acting as a gateway, nginx is. An nginx sends the html. All apps should check the status code for codes like this one that don't come from apps.

[–] [email protected] 1 points 1 year ago

Definitely jerboa

[–] [email protected] 1 points 1 year ago (3 children)

I would say Lemmy issue. This is probably a default 502 internal sever error response (which I've been getting repeatedly from lemmy.world). Jerboa (I don't use it btw) is only trying to parse the expected json response. Yes the app could handle the error more gracefully but if Lemmy didn't respond with an error jerboa wouldn't need to.

[–] [email protected] 6 points 1 year ago (2 children)

personally I'd say it's a Jerboa thing. the app should retry loading because sometimes I refresh after this happening and it immediately loads the proper content.

with all the different instances this sort of thing has to be kept in mind

[–] [email protected] 8 points 1 year ago (2 children)

Just retry is usually a bad ideia, specially that this problem is probably an overload, just adding retries can makes the problem.even worse with the app ddosing the server

[–] [email protected] 2 points 1 year ago

just adding retries can makes the problem.even worse with the app ddosing the server

Twitter has some experience with that

[–] [email protected] -2 points 1 year ago (1 children)

Lemmy realy should not randomly emit errors for no reason, there should be no need for retries in this case. If the specification specifies a JSON response, and the server randomly provides HTML, that is a bug in the server.

[–] [email protected] 5 points 1 year ago

When you get a 502 error, that's not coming from lemmy, it's coming from nginx. If you're saying that nginx should send any error data along with the status in json if the accept headers require it, that's a task for nginx but it wouldn't happen in this case anyway since the json wouldn't be what they were expecting anyway. The app should be handling non success responses better is the point being made here.

[–] [email protected] 1 points 1 year ago* (last edited 1 year ago) (1 children)

[This comment has been deleted by an automated system]

[–] [email protected] 1 points 1 year ago

Yeah this makes more sense than my original comment

[–] [email protected] -1 points 1 year ago (1 children)

Lemmy realy should not randomly emit errors for no reason, there should be no need for retries in this case. If the specification specifies a JSON response, and the server randomly provides HTML, that is a bug in the server.

[–] [email protected] 5 points 1 year ago

The error is not being emitted by Lemmy though. The 502 error message is returned to the client by nginx when the Lemmy server doesn't respond within the a certain time.