this post was submitted on 24 Jun 2023
22 points (95.8% liked)

Python

6287 readers
7 users here now

Welcome to the Python community on the programming.dev Lemmy instance!

πŸ“… Events

PastNovember 2023

October 2023

July 2023

August 2023

September 2023

🐍 Python project:
πŸ’“ Python Community:
✨ Python Ecosystem:
🌌 Fediverse
Communities
Projects
Feeds

founded 1 year ago
MODERATORS
 

Sometimes unused class or function manages to slip into code base. Static code checkers like ruff, flake8 does not have rules for detecting such globally unused code.

I tried using vulture, but it has too many false positives to have it as part of CI/CD pipeline.

I have tried to implement my own, more reliable check for global deadcode detection.

Please let me know what you think about it.

you are viewing a single comment's thread
view the rest of the comments
[–] qwop 2 points 1 year ago (1 children)

From a quick look at the code it looks like it uses regex to extract any name assignments and compares that to usages. This approach seems very limited as it has no understanding of context (e.g. the same name used in multiple places, or special methods like __add__ on classes that aren't called manually).

I'd be interested to know what false positives in vulture this solves. The main false positives I've found with vulture are:

  • Names that are publicly exposed in a library but not actually used
  • Methods in classes that are called by an external parent class defined in some external module.
  • Special cases (for example unittest functions, which aren't called manually, or fastapi route decorator functions)

I don't think this project would solve any of those cases (and in some cases I think vulture has special casing to handle things better).

[–] niekas 2 points 1 year ago* (last edited 1 year ago)

Yes, you are right πŸ‘ Thanks for pointing this out. And yes, my package is only a subset of vulture functionality.