this post was submitted on 15 Oct 2023
200 points (95.0% liked)

Programmer Humor

32048 readers
1611 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 30 points 11 months ago (3 children)

I remember one GitHub project that implemented some algorithm (I think it was Dijkstra's) but only used 4 or 5 single letter variables and just kept reusing them.

[–] [email protected] 28 points 11 months ago (2 children)

When I was in college, I had a guy that I was working on a project with that did this constantly. At one point I looked at one of his files and the variables were named a, b, c, aa, ab, ac, ba, bb, etc. That when I was like, bro, you gotta stop doing this.

[–] [email protected] 33 points 11 months ago

"Inside you there are two wolves..." or something:

Option 1: Sit down with them and go line by line through it. Make him identify each variable's purpose and then immediately find and replace to rename every instance with a more descriptive name.

Option 2: Small script to shuffle the variable names in his code around after each of his commits.

[–] [email protected] 4 points 11 months ago

The guy thinks in Excel.

[–] [email protected] 8 points 11 months ago (1 children)

When you are used to math equations, it's easy to slip into that habit.

[–] [email protected] 7 points 11 months ago (2 children)

Single letter variables, yes. Reusing them? No.

[–] [email protected] 4 points 11 months ago (1 children)

Only if they are well-known in the language you’re using or domain you’re writing for. x and y are fine for coordinates. i and j are fine for loop indices. But abbreviating things unnecessarily is bad IMO. s = GetSession() is too terse, for example.

[–] [email protected] 3 points 11 months ago

No, I mean single-letter vars are standard in physics and math, but reusing vars is not acceptable. Obviously they're not good practice except in the scenarios you describe, but mathies gonna math.

[–] [email protected] 6 points 11 months ago* (last edited 11 months ago)

Maybe they had a background in low-level assembly code? If you're writing assembly that's kinda sorta how you'd handle registers.