def _cleanup(self) -> None:                                                                                                                                                                                                             
    dirs, files = partition(lambda f: f.is_file(), self._tmp_dir.rglob("*"))                                                                                                                                                            
    [file.unlink() for file in files]                                                                                                                                                                                                   
    [dir.rmdir() for dir in dirs]                                                                                                                                                                                                       
    self._tmp_dir.rmdir()

you are viewing a single comment's thread
view the rest of the comments

[–] slurp 1 points 1 year ago* (last edited 1 year ago) (1 children)

For me, the only reason I wouldn't do this is to include debug level logging of which files are being removed.

That said, how about using tempfile's TemporaryDirectory to handle the clearing up of the temporary directory?

[–] slurp 1 points 1 year ago

Though you might want to consider whether you want it to remove as much as possible in the case of permissions errors, in which case you might want exception handling around each unlink call, with it raising an exception after it's tried clearing everything if anything went wrong.