this post was submitted on 30 Aug 2023
34 points (100.0% liked)

Experienced Devs

3982 readers
1 users here now

A community for discussion amongst professional software developers.

Posts should be relevant to those well into their careers.

For those looking to break into the industry, are hustling for their first job, or have just started their career and are looking for advice, check out:

founded 1 year ago
MODERATORS
snowe
jmk1ng
drewsiferr
34
How much flakiness do you tolerate in end to end tests? (self.experienced_devs)
submitted 1 year ago* (last edited 1 year ago) by kersplort to c/experienced_devs
22 comments fedilink hide all child comments
 

End to end and smoke tests give a really valuable angle on what the app is doing and can warn you about failures before they happen. However, because they're working with a live app and a live database over a live network, they can introduce a lot of flakiness. Beyond just changes to the app, different data in the environment or other issues can cause a smoke test failure.

How do you handle the inherent flakiness of testing against a live app?

When do you run smokes? On every phoenix branch? Pre-prod? Prod only?

Who fixes the issues that the smokes find?

you are viewing a single comment's thread
view the rest of the comments
[–] kersplort 6 points 1 year ago (1 children)

My team has just decided to make working smokes a mandatory part of merging a PR. If the smokes don't work on your branch, it doesn't merge to main. I'm somewhat conflicted - on one hand, we had frequent breaks in the smokes that developers didn't fix, including ones that represented real production issues. On the other, smokes can fail for no reason and are time consuming to run.

We use playwright, running on github actions. The default free tier runner has been awful, and we're moving to larger runners on the platform. We have a retry policy on any smokes that need to run in a step by step order, and we aggressively prune and remove smokes that frequently fail or don't test for real issues.

[–] [email protected] 4 points 1 year ago (1 children)

Shouldn't you find out, why the smoke tests keep failing? It's not a good sign, if you can't even guarantee stability in a controlled environment.

[–] kersplort 2 points 1 year ago (1 children)

It's not a fully controlled environment, that is the point of smokes.

[–] [email protected] 1 points 1 year ago (1 children)

How do you not fully control the environment your PRs are tested in?

[–] kersplort 1 points 1 year ago

dependencies.