this post was submitted on 01 Jul 2024
328 points (92.1% liked)

LinkedinLunatics

3580 readers
58 users here now

A place to post ridiculous posts from linkedIn.com

(Full transparency.. a mod for this sub happens to work there.. but that doesn't influence his moderation or laughter at a lot of posts.)

founded 1 year ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 213 points 4 months ago* (last edited 4 months ago) (5 children)

I would reject this pull request. Why is the indenting all over the place? Why is your keyword capitalisation all over the place? WHY YELLOW?!

Edit: the more I look at this the more it pisses me off. Wtf is going on with your kerning? Just random number and placement of spaces. Also, why is the table name in caps? Who does that? Select * is lazy. Do you really need every field about a girl? Really? Worst of all, not a limited request. I sware this is just the kind of thing that would return 30 million rows and brick the database for twenty seconds.

[–] [email protected] 50 points 4 months ago

You are now a Certified Rejector. Stay sharp, keep the wheel rolling.

[–] [email protected] 15 points 4 months ago

I would like to subscribe to your newsletter.

[–] [email protected] 12 points 4 months ago

You forgot some: Why is there no space after SELECT?

Why are boyfriend and smallwaist not questions like is_cute and is_crazy? Either all boils are with a verb or none.

Also why is smallwaist not in snake case? It should be small_waist (or better yet has_small_waist or even better waist = "small")

Also also boyfriend should be null not false, this would solve multiple issues.

And finally the only positive thing is the * itself, because selecting only body would be even worse. 🤣

[–] [email protected] 7 points 4 months ago (1 children)

Shouldn't boyfriend be a reference to another table?

[–] [email protected] 7 points 4 months ago (1 children)

BF has no referential integrity

[–] [email protected] 6 points 4 months ago

That's (part of) why it should be a separate table to map the relation "Relationship". People can have more than one (polyamory, infidelity), and you could track fields like the start, end, status (e.g. flirting, dating, committed, engaged, married, ended) in there.

[–] mark 3 points 4 months ago* (last edited 4 months ago)

Yesssss, bro 😀