I can't tell who you hate more. Yourself or your teammates lol.
this post was submitted on 17 Jun 2023
23 points (96.0% liked)
Programming Horror
1894 readers
1 users here now
Welcome to Programming Horror!
This is a place to share strange or terrible code you come across.
For more general memes about programming there's also Programmer Humor.
Looking for mods. If youre interested in moderating the community feel free to dm @[email protected]
Rules
- Keep content in english
- No advertisements (this includes both code in advertisements and advertisement in posts)
- No generated code (a person has to have made it)
Credits
founded 1 year ago
MODERATORS
You can't beat yourself up too much over code you wrote in the past, especially if you're just starting and you learn from your mistakes.
I'm the only dev at my company, so most of the code was written by an external dev a while back. They very occasionally do some work for us still and their code written today is just a shitty as it was 4 years ago.
Context please, what is this bit shifting shenanigans that im witnessing right now?
PA_ prefixed functions seem to be from palibds, which is a Nintendo DS homebrew development library.
DS being a constrained device it is logical that whoever wrote this code packed multiple byte-sized info into a bigger 16-bit short and using bit shifting to extract a specific byte
You're right, this is some homebrew I wrote for my DS when I was in highschool.
But it was nothing as clever or logical as that! I think I had read somewhere that floats were really expensive on the DS ARM9 CPU, as was division (?). So to allow fractional values for object positions, etc, you would store them in an integer at 256x their true value, then shift it by 8 to the right to 'divide' by 256 and get the proper value back.
Not sure whether this was actually true, but either way this would've been completely cancelled out by calling that 'lowestXInObj' function 20 times per frame - it loops through every object in the scene!
Should've used fixed point integers!
view more: next ›