this post was submitted on 13 Sep 2023
8 points (100.0% liked)

C++

1765 readers
1 users here now

The center for all discussion and news regarding C++.

Rules

founded 1 year ago
MODERATORS
lysdexic
[email protected]
Nihili0
8
I have a problem creating trees (lemmy.world)
submitted 1 year ago by [email protected] to c/cpp
8 comments fedilink hide all child comments
 

I was trying to creating a red-black tree, and when trying to get data out of it, it always returned the same value, so i decided to try to create a very simple binary search tree, and i got the same result, so i wonder, ¿what i'm doing wrong when trying to create trees in c++? Here is the code: https://pastebin.com/L2yJJ3Nu

you are viewing a single comment's thread
view the rest of the comments
[–] lawmurray 3 points 1 year ago* (last edited 1 year ago) (3 children)

Your get() function will always just return the value of the root node. I think you mean to have return get(value, ...) in each of its if statements.

[–] [email protected] 2 points 1 year ago (2 children)

it worked, thank you :D

[–] lawmurray 2 points 1 year ago (1 children)

Nice, good luck with it from here!

[–] [email protected] 1 points 1 year ago

i managed to do it (or thats what i think), the tree apparently works, but i dont know if its balanced, can you have a look at my code? i want to know if my tree is balanced correctly, here is the code: https://pastebin.com/ineG07b2 (PS: im aware that this code doesnt guarantee that the root will be black, the wikipedia article says that the black root is not a strict requirement by all the authors, so i decided to omit that)