Programming

17495 readers

88 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Follow the programming.dev instance rules
Keep content related to programming in some way
If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]

founded 1 year ago

MODERATORS

snowe

Ategon

[email protected]

124

Is there a place where you can request code reviews on opensource software? (self.programming)

submitted 1 year ago by onlinepersona to c/programming

36 comments fedilink hide all child comments

Many of us write opensource code in a void: nobody ever looks at it, uses it nor reviews it. We are the only users and authors.

In order to improve, where can we get our code reviewed? I don't mean professionally, just from like-minded individuals.

you are viewing a single comment's thread
view the rest of the comments

[–] stifle867 72 points 1 year ago (13 children)

This is not an answer to your question but it's tangentially related.

Someone I greatly respected ran an open-source project with the policy of merge everything. Completely flip this idea of carefully review, debate and revise every PR. His theory was that it helps to build an open community, and if something breaks someone else will revert that commit. He says that the main branch was almost always stable, a massive improvement to how it was run previously. He passed several years ago and for some reason this reminded me of him.

I guess what I'm trying to say is if you get something out there that people find useful, the code will be looked at. It doesn't help you if you're looking for someone to collaborate sorry.

[–] varsock 4 points 1 year ago (1 children)

I've actually found his blog where he talks about this "optimistic merge"

http://hintjens.com/blog:106

[–] stifle867 4 points 1 year ago (2 children)

There's a number of them as the idea grows. See also the C4 process RFC

[–] lysdexic 3 points 1 year ago

See also the C4 process RFC

What an unfortunate name.

https://c4model.com/

[–] onlinepersona 2 points 1 year ago (1 children)

mbin (fork of kbin) is currently trying to implement the process.

[–] stifle867 1 points 1 year ago (1 children)

It's great to see the attempt and also an example of what the C4 guidelines are made to avoid.

Notice how many comments are little nitpicks about this and that. Completely stalling the commit and getting further away from the original point of C4 which is to reduce contributor friction and avoid these kind of endless discussions on PRs.

I don't want to be too critical because some of that is a clear lack of understanding of the motivations of C4 which is explained more thoroughly in Pieter's blog posts. You don't want to adopt a contributor guidelines that you don't understand of course.

IMO it's better just to implement it as-is and start using it in practice rather than bikeshedding.